katana/PIbd21.TeryokhinA.S.Seaplane.Common.
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-21. Teryokhin A.S. Lab work 01 #1

Closed
katana wants to merge 1 commits from Lab1Base into main
pull from: Lab1Base
merge into: katana:main
Conversation 1 Commits 1 Files Changed 16 +839 -50
katana commented 2023-10-04 20:39:03 +04:00
Owner
Copy Link
No description provided.
katana added 1 commit 2023-10-04 20:39:03 +04:00
eegov approved these changes 2023-10-15 16:32:19 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
ProjectSeaplane/ProjectSeaplane/DrawingSeaplane.cs
@ -0,0 +55,4 @@
public bool Init(int speed, double weight, Color bodyColor, Color
additionalColor, bool boat, bool floater, int width, int height)
{
if (width < _pictureWidth || height < _pictureHeight)
eegov commented 2023-10-15 16:31:28 +04:00
Collaborator
Copy Link

Что тут проверяется????

Что тут проверяется????
ProjectSeaplane/ProjectSeaplane/DrawingSeaplane.cs
@ -0,0 +80,4 @@
/// <param name="y">Координата Y</param>
public void SetPosition(int x, int y)
{
if (x <= _pictureWidth - _seaplaneWidth && y <= _pictureHeight - _seaplaneHeight)
eegov commented 2023-10-15 16:31:41 +04:00
Collaborator
Copy Link

Не учтены все условия, при которых объект может выйти за границы

Не учтены все условия, при которых объект может выйти за границы
ProjectSeaplane/ProjectSeaplane/DrawingSeaplane.cs
@ -0,0 +82,4 @@
{
if (x <= _pictureWidth - _seaplaneWidth && y <= _pictureHeight - _seaplaneHeight)
{
_startPosX = x;
eegov commented 2023-10-15 16:31:49 +04:00
Collaborator
Copy Link

Нет корректировки координат, если при текущих объект "выходит" за границы

Нет корректировки координат, если при текущих объект "выходит" за границы
eegov closed this pull request 2023-10-15 16:32:25 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
eegov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: katana/PIbd21.TeryokhinA.S.Seaplane.Common.#1
No description provided.
Delete Branch "Lab1Base"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?