Vyacheslav/PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-23. Ivanov V.N. Lab Work 01 #1

Closed
Vyacheslav wants to merge 4 commits from LabWork1 into main
pull from: LabWork1
merge into: Vyacheslav:main
Conversation 0 Commits 4 Files Changed 16 +794 -75
Vyacheslav commented 2023-09-19 12:12:11 +04:00
Owner
Copy Link
No description provided.
Vyacheslav added 4 commits 2023-09-19 12:12:11 +04:00
Vyacheslav changed title from PIbd-23. Ivanov_V.N.. Lab Work 01 to PIbd-23. Ivanov_V.N. Lab Work 01 2023-09-19 12:22:03 +04:00
Vyacheslav changed title from PIbd-23. Ivanov_V.N. Lab Work 01 to PIbd-23. Ivanov V.N. Lab Work 01 2023-09-19 12:22:33 +04:00
Vyacheslav requested review from eegov 2023-09-20 21:57:00 +04:00
eegov approved these changes 2023-09-23 09:14:51 +04:00
eegov left a comment
Owner
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/DrawningDoubleDeckerBus.cs
@ -0,0 +63,4 @@
{
_pictureWidth = width;
_pictureHeight = height;
if (_pictureHeight < _busHeight || _pictureWidth < _busWidth)
eegov commented 2023-09-23 09:13:40 +04:00
Owner
Copy Link

Сначала выполняются проверки и только потом, если они пройдены успешно, запоминаются данные

Сначала выполняются проверки и только потом, если они пройдены успешно, запоминаются данные
PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/DrawningDoubleDeckerBus.cs
@ -0,0 +80,4 @@
/// <param name="y">Координата Y</param>
public void SetPosition(int x, int y)
{
_startPosX = Math.Min(x, _pictureWidth - _busWidth);
eegov commented 2023-09-23 09:13:51 +04:00
Owner
Copy Link

Не учтены все условия, при которых объект может выйти за границы

Не учтены все условия, при которых объект может выйти за границы
PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base/EntityDoubleDeckerBus.cs
@ -0,0 +35,4 @@
/// <summary>
/// Признак (опция) наличия гоночной полосы
/// </summary>
public bool RoadLine { get; private set; }
eegov commented 2023-09-23 09:14:21 +04:00
Owner
Copy Link

У автобуса да еще двухэтажного????

У автобуса да еще двухэтажного????
eegov closed this pull request 2023-09-23 09:14:56 +04:00
Vyacheslav requested review from eegov 2023-09-26 18:32:35 +04:00
Vyacheslav removed review request for eegov 2023-09-26 18:32:40 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Vyacheslav/PIbd-23_Ivanov_V.N._DoubleDeckerBus._Base#1
No description provided.
Delete Branch "LabWork1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?