Kuznetsov_Anatoliy/PIbd22_Kuznetsov_A.V._Excavator_Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd22_Kuznetsov_A.V._lab1 #2

Closed
Kuznetsov_Anatoliy wants to merge 2 commits from lab1 into main
pull from: lab1
merge into: Kuznetsov_Anatoliy:main
Conversation 1 Commits 2 Files Changed 15 +3443
Kuznetsov_Anatoliy commented 2023-12-15 21:22:29 +04:00
Owner
Copy Link
No description provided.
Kuznetsov_Anatoliy added 2 commits 2023-12-15 21:22:29 +04:00
PIbd22_Kuznetsov_A.V._lab1 a4f6cf4be8
PIbd22_Kuznetsov_A.V._lab1 610b165409
Kuznetsov_Anatoliy changed title from lab1 to PIbd22_Kuznetsov_A.V._lab1 2023-12-19 19:19:38 +04:00
eegov approved these changes 2023-12-27 20:19:01 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
Excavator/DrawingExc.cs
@@ -0,0 +18,4 @@
private readonly int _excHeight = 124;
public bool Init(EntityExcavator bus, int width, int height)
{
_pictureWidth = width;
eegov commented 2023-12-27 20:17:49 +04:00
Collaborator
Copy Link

Сначала выполняются проверки и только потом, если они пройдены успешно, запоминаются данные

Сначала выполняются проверки и только потом, если они пройдены успешно, запоминаются данные
Excavator/DrawingExc.cs
@@ -0,0 +56,4 @@
switch (direction)
{
case Direction.Left:
if (_startPosX - EntityExcavator.Step > -17)
eegov commented 2023-12-27 20:18:27 +04:00
Collaborator
Copy Link

Не должно быть "магических" чисел

Не должно быть "магических" чисел
eegov closed this pull request 2023-12-27 20:19:07 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
eegov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
eegov Kuznetsov_Anatoliy
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Kuznetsov_Anatoliy/PIbd22_Kuznetsov_A.V._Excavator_Base#2
Delete Branch "lab1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?