Egor/PIbd_23_Kislitsa_E.D_AirFighter_Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-23. Kislitsa E.D. Lab work 01 #1

Closed
Egor wants to merge 1 commits from Laba1 into main
pull from: Laba1
merge into: Egor:main
Conversation 0 Commits 1 Files Changed 19 +871 -84
Egor commented 2023-09-21 18:16:02 +04:00
Owner
Copy Link
No description provided.
Egor added 1 commit 2023-09-21 18:16:03 +04:00
eegov approved these changes 2023-09-23 09:16:49 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
AirFighter/DrawningAirFighter.cs
@ -0,0 +77,4 @@
// TODO: Изменение x, y
_startPosX = x;
_startPosY = y;
if (x + _airfighterWidth >= _pictureWidth || y + _airfighterHeight >= _pictureHeight)
eegov commented 2023-09-23 09:15:44 +04:00
Collaborator
Copy Link

Не учтены все условия, при которых объект может выйти за границы

Не учтены все условия, при которых объект может выйти за границы
AirFighter/DrawningAirFighter.cs
@ -0,0 +79,4 @@
_startPosY = y;
if (x + _airfighterWidth >= _pictureWidth || y + _airfighterHeight >= _pictureHeight)
{
_startPosX = 1;
eegov commented 2023-09-23 09:15:53 +04:00
Collaborator
Copy Link

Рекомендуется не использовать константы, а корректировать имеющиеся значения

Рекомендуется не использовать константы, а корректировать имеющиеся значения
eegov closed this pull request 2023-09-23 09:16:59 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Egor/PIbd_23_Kislitsa_E.D_AirFighter_Base#1
No description provided.
Delete Branch "Laba1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?