mallafeev/PIbd-21_MalafeevL.S._Cruiser_Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-21-MalafeevL.S._Cruiser_Base_Lab1 #1

Closed
mallafeev wants to merge 1 commits from lab1 into main
pull from: lab1
merge into: mallafeev:main
Conversation 0 Commits 1 Files Changed 18 +815 -81
mallafeev commented 2023-09-25 11:16:43 +04:00
Owner
Copy Link
No description provided.
mallafeev added 1 commit 2023-09-25 11:16:44 +04:00
mallafeev requested review from eegov 2023-09-25 11:17:16 +04:00
eegov approved these changes 2023-10-15 14:23:05 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
Cruiser/DrawingCruiser.cs
@ -0,0 +39,4 @@
/// <summary>
/// Цвет для палубы
/// </summary>
public Color PalubaColor { get; private set; }
eegov commented 2023-10-15 14:21:26 +04:00
Collaborator
Copy Link

Это свойства, относящиеся к сущности, тут их быть не должно

Это свойства, относящиеся к сущности, тут их быть не должно
Cruiser/DrawingCruiser.cs
@ -0,0 +74,4 @@
{
if (width < _cruiserWidth || height < _cruiserHeight)
{
_pictureHeight = _cruiserHeight + 100;
eegov commented 2023-10-15 14:21:41 +04:00
Collaborator
Copy Link

Почему 100? Почему не 50?

Почему 100? Почему не 50?
Cruiser/DrawingCruiser.cs
@ -0,0 +97,4 @@
{
if (x < 0 || y < 0)
{
return;
eegov commented 2023-10-15 14:21:54 +04:00
Collaborator
Copy Link

Не выход, а корректировка

Не выход, а корректировка
Cruiser/DrawingCruiser.cs
@ -0,0 +101,4 @@
}
if (x > _pictureWidth || y > _pictureHeight)
{
return;
eegov commented 2023-10-15 14:21:57 +04:00
Collaborator
Copy Link

Не выход, а корректировка

Не выход, а корректировка
Cruiser/resources/someLost.txt
@ -0,0 +1,31 @@
private void Form1_Load(object sender, EventArgs e)
eegov commented 2023-10-15 14:22:55 +04:00
Collaborator
Copy Link

Что это такое???

Что это такое???
eegov closed this pull request 2023-10-15 14:23:09 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mallafeev/PIbd-21_MalafeevL.S._Cruiser_Base#1
No description provided.
Delete Branch "lab1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?