goldfest228/PIBD-21_Lobashov_I_D_SelfPropelledArtilleryUnit_Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ПИбд-21 Лобашов Иван 1 лаб простая #1

Closed
goldfest228 wants to merge 1 commits from lab1 into main
pull from: lab1
merge into: goldfest228:main
Conversation 0 Commits 1 Files Changed 8 +778 -2
goldfest228 commented 2023-11-07 13:32:29 +04:00
Owner
Copy Link
No description provided.
goldfest228 added 1 commit 2023-11-07 13:32:30 +04:00
goldfest228 changed title from ПИбд-21 Лобашов Иван 1 лаб to WIP: ПИбд-21 Лобашов Иван 1 лаб 2023-11-07 13:33:26 +04:00
goldfest228 changed title from WIP: ПИбд-21 Лобашов Иван 1 лаб to ПИбд-21 Лобашов Иван 1 лаб простая 2023-11-07 13:34:00 +04:00
goldfest228 changed title from ПИбд-21 Лобашов Иван 1 лаб простая to WIP: ПИбд-21 Лобашов Иван 1 лаб простая 2023-11-07 13:45:32 +04:00
goldfest228 changed title from WIP: ПИбд-21 Лобашов Иван 1 лаб простая to ПИбд-21 Лобашов Иван 1 лаб простая 2023-11-07 13:45:39 +04:00
eegov approved these changes 2023-11-11 16:41:07 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
SelfPropelledArtilleryUnit/SelfPropelledArtilleryUnit/Direction.cs
@ -0,0 +6,4 @@
namespace SelfPropelledArtilleryUnit
{
public enum DirectionType
eegov commented 2023-11-11 16:39:33 +04:00
Collaborator
Copy Link

Имя файла не соответствует имени элемента проекта

Имя файла не соответствует имени элемента проекта
SelfPropelledArtilleryUnit/SelfPropelledArtilleryUnit/DrawningUsta.cs
@ -0,0 +52,4 @@
public void SetPosition(int x, int y)
{
// TODO: Изменение x, y
if (x <= _pictureWidth - _ustaWidth && y <= _pictureHeight - _ustaHeight)
eegov commented 2023-11-11 16:40:01 +04:00
Collaborator
Copy Link

Нет корректировки координат, если при текущих объект "выходит" за границы

Нет корректировки координат, если при текущих объект "выходит" за границы
SelfPropelledArtilleryUnit/SelfPropelledArtilleryUnit/DrawningUsta.cs
@ -0,0 +88,4 @@
}
else if (_startPosY + 7 - EntityUsta.Step < 0)
{
_startPosY = _startPosY - _startPosY + 10;
eegov commented 2023-11-11 16:40:23 +04:00
Collaborator
Copy Link

Никаких "+ 10" быть не должно

Никаких "+ 10" быть не должно
SelfPropelledArtilleryUnit/SelfPropelledArtilleryUnit/DrawningUsta.cs
@ -0,0 +282,4 @@
g.DrawPath(pen, path7);
g.FillPath(BodyColor, path7);
eegov commented 2023-11-11 16:40:39 +04:00
Collaborator
Copy Link

Много пустых строк

Много пустых строк
eegov closed this pull request 2023-11-11 16:41:17 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: goldfest228/PIBD-21_Lobashov_I_D_SelfPropelledArtilleryUnit_Base#1
No description provided.
Delete Branch "lab1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?