dex_moth/PIbd-22_Isaeva_A.I._Airbus_Base
dex_moth/PIbd-22_Isaeva_A.I._Airbus_Base
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-22. Isaeva A.I. Lab work 01 #2

Closed
dex_moth wants to merge 18 commits from lab1 into main
pull from: lab1
merge into: dex_moth:main
Conversation 0 Commits 18 Files Changed 15 +852
dex_moth commented 2023-10-15 16:05:01 +04:00
Owner
Copy Link
No description provided.
dex_moth added 1 commit 2023-10-15 16:05:01 +04:00
dex_moth changed title from PIbd-22. Isaeva A.I. Lab work 01 to WIP: PIbd-22. Isaeva A.I. Lab work 01 2023-10-15 16:06:07 +04:00
dex_moth changed title from WIP: PIbd-22. Isaeva A.I. Lab work 01 to PIbd-22. Isaeva A.I. Lab work 01 2023-10-15 16:06:16 +04:00
eegov was assigned by dex_moth 2023-10-15 16:06:31 +04:00
eegov was unassigned by dex_moth 2023-10-15 16:06:47 +04:00
dex_moth requested review from eegov 2023-10-15 16:07:34 +04:00
eegov approved these changes 2023-10-15 17:27:01 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
AirBus/DrawningAirBus.cs Outdated
@ -0,0 +25,4 @@
public bool Init(int speed, double weight, Color bodyColor, Color additionalColor, int width, int height)
{
pictureWidht = width;
eegov commented 2023-10-15 17:25:49 +04:00
Collaborator
Copy Link

Нет проверки, что объект можно "вписать" в размеры формы

Нет проверки, что объект можно "вписать" в размеры формы
AirBus/DrawningAirBus.cs Outdated
@ -0,0 +36,4 @@
//установка позиции
public void SetPosition(int x, int y)
{
if (x >= 0 && x + airbusWidth <= pictureWidht && y >= 0 && y + airbusHeight <= pictureHeight)
eegov commented 2023-10-15 17:25:58 +04:00
Collaborator
Copy Link

Нет корректировки координат, если при текущих объект "выходит" за границы

Нет корректировки координат, если при текущих объект "выходит" за границы
AirBus/Form1.cs Outdated
@ -0,0 +1,95 @@
namespace AirBus
eegov commented 2023-10-15 17:26:40 +04:00
Collaborator
Copy Link

Имя файла не соответствует имени класса

Имя файла не соответствует имени класса
AirBus/Form1.cs Outdated
@ -0,0 +29,4 @@
Draw();
}
private void Form1_Load(object sender, EventArgs e)
eegov commented 2023-10-15 17:26:48 +04:00
Collaborator
Copy Link

Пустых методов быть не должно

Пустых методов быть не должно
eegov closed this pull request 2023-10-15 17:27:08 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dex_moth/PIbd-22_Isaeva_A.I._Airbus_Base#2
No description provided.
Delete Branch "lab1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?