chtzsch/Pibd-21_Ievlewa_M.D._SpeedBoat_Normal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ievlewa_lab04_Base #4

Closed
chtzsch wants to merge 2 commits from lab_4 into lab_3
pull from: lab_4
merge into: chtzsch:lab_3
Conversation 1 Commits 2 Files Changed 5 +359 -81
chtzsch commented 2023-11-01 12:16:21 +04:00
Owner
Copy Link
No description provided.
chtzsch added 2 commits 2023-11-01 12:16:22 +04:00
eegov approved these changes 2023-11-05 15:06:09 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
speed_Boat/speed_Boat/BoatsGenericStorage.cs
@ -0,0 +47,4 @@
{
if (_boatStorages.ContainsKey(name))
{
MessageBox.Show("Словарь уже содержит набор с таким названием", "Ошибка",
eegov commented 2023-11-05 15:05:25 +04:00
Collaborator
Copy Link

В классах логики не пишут в консоль, не выводят сообщения. Максимум - запись в логи идет

В классах логики не пишут в консоль, не выводят сообщения. Максимум - запись в логи идет
speed_Boat/speed_Boat/BoatsGenericStorage.cs
@ -0,0 +62,4 @@
public void DelSet(string name)
{
BoatsGenericCollection<DrawingBoat, DrawingObjectBoat> boat;
if (_boatStorages.TryGetValue(name, out boat))
eegov commented 2023-11-05 15:05:50 +04:00
Collaborator
Copy Link

ContainsKey здесь уместнее, получать удаляемый объект не нужно

ContainsKey здесь уместнее, получать удаляемый объект не нужно
eegov closed this pull request 2023-11-05 15:06:14 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
eegov
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chtzsch/Pibd-21_Ievlewa_M.D._SpeedBoat_Normal#4
No description provided.
Delete Branch "lab_4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?