YakovlevMaxim/PIbd-21_Yakovlev_M.G._CarRepairShop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PIbd-21 Yakovlev M.G. lab work 4 #5

Closed
YakovlevMaxim wants to merge 2 commits from Lab4_Base into Lab3_Base
pull from: Lab4_Base
merge into: YakovlevMaxim:Lab3_Base
Conversation 0 Commits 2 Files Changed 47 +2576 -17
YakovlevMaxim commented 2024-03-31 12:51:08 +04:00
Owner
Copy Link
No description provided.
YakovlevMaxim added 2 commits 2024-03-31 12:51:10 +04:00
YakovlevMaxim requested review from eegov 2024-03-31 12:51:19 +04:00
eegov approved these changes 2024-03-31 18:30:14 +04:00
eegov left a comment
Collaborator
Copy Link

Не во все реализации OrderStorage были внесены требуемые изменения

Проверено

Не во все реализации OrderStorage были внесены требуемые изменения Проверено
CarRepairShop/CarRepairShopBusinessLogic/BusinessLogics/ReportLogic.cs
@ -0,0 +36,4 @@
public List<ReportRepairComponentViewModel> GetRepairComponent()
{
var components = _componentStorage.GetFullList();
eegov commented 2024-03-31 18:28:44 +04:00
Collaborator
Copy Link

При получении изделий, у них уже есть список компонент, отдельно его получать не требуется

При получении изделий, у них уже есть список компонент, отдельно его получать не требуется
CarRepairShop/CarRepairShopDatabaseImplement/Implements/OrderStorage.cs
@ -21,3 +23,3 @@
public List<OrderViewModel> GetFilteredList(OrderSearchModel model)
{
if(!model.Id.HasValue)
if (!model.DateFrom.HasValue && !model.DateTo.HasValue)
eegov commented 2024-03-31 18:29:22 +04:00
Collaborator
Copy Link

Нужно было дополнить условие, а не заменять его

Нужно было дополнить условие, а не заменять его
CarRepairShop/CarRepairShopView/FormReportOrders.Designer.cs
@ -0,0 +111,4 @@
ClientSize = new Size(916, 454);
Controls.Add(panel);
Name = "FormReportOrders";
Text = "FormReportOrders";
eegov commented 2024-03-31 18:29:44 +04:00
Collaborator
Copy Link

Заголовок формы оформлен неверно

Заголовок формы оформлен неверно
eegov closed this pull request 2024-03-31 18:30:47 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: YakovlevMaxim/PIbd-21_Yakovlev_M.G._CarRepairShop#5
No description provided.
Delete Branch "Lab4_Base"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?