TurnerIlya/PIbd-22_Turner_I.A._AntiAircraftGun._Base
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Turner I.A. LabWork03 #3

Merged
eegov merged 3 commits from LabWork03 into LabWork02 2022-10-07 09:35:22 +04:00
Conversation 0 Commits 3 Files Changed 13 +705 -320
TurnerIlya commented 2022-10-03 19:59:38 +04:00
Owner
Copy Link
No description provided.
TurnerIlya added 3 commits 2022-10-03 19:59:38 +04:00
TurnerIlya requested review from eegov 2022-10-03 20:00:52 +04:00
eegov approved these changes 2022-10-07 09:35:09 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
AntiAircraftGun/AntiAircraftGun/FormAntiAircraftGun.cs
@ -5,6 +5,10 @@ namespace AntiAircraftGun
public partial class FormAntiAircraftGun : Form
eegov commented 2022-10-07 09:32:56 +04:00
Collaborator
Copy Link

Не добавлена работа с ColorDialog

Не добавлена работа с ColorDialog
AntiAircraftGun/AntiAircraftGun/SetAntiAircraftGunsGeneric.cs
@ -0,0 +36,4 @@
/// <returns></returns>
public int Insert(T antiAircraftGun)
{
if (_places[Count - 1] == null)
eegov commented 2022-10-07 09:34:19 +04:00
Collaborator
Copy Link

Правильнее было вызвать Insert(T obj, 0);

Правильнее было вызвать Insert(T obj, 0);
AntiAircraftGun/AntiAircraftGun/SetAntiAircraftGunsGeneric.cs
@ -0,0 +87,4 @@
{
T removed = _places[position];
_places[position] = null;
if (position < Count - 1)
eegov commented 2022-10-07 09:34:55 +04:00
Collaborator
Copy Link

Лишнее действие, сдвиг делает другой метод

Лишнее действие, сдвиг делает другой метод
eegov merged commit 2dcbb559bf into LabWork02 2022-10-07 09:35:22 +04:00
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TurnerIlya/PIbd-22_Turner_I.A._AntiAircraftGun._Base#3
No description provided.
Delete Branch "LabWork03"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?