Kate/ISEbd-21_Vasina_E.S._ComputersShop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ISEbd-21 Vasina E. S. lab_3 #5

Closed
Kate wants to merge 4 commits from lab_3 into lab_2
pull from: lab_3
merge into: Kate:lab_2
Conversation 0 Commits 4 Files Changed 16 +1051 -5
Kate commented 2023-05-10 01:17:13 +04:00
Owner
Copy Link
No description provided.
Kate added 4 commits 2023-05-10 01:17:13 +04:00
Kate requested review from eegov 2023-05-10 01:17:23 +04:00
eegov approved these changes 2023-05-27 21:10:19 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
ComputersShop/ComputersShopDatabaseImplement/Implements/OrderStorage.cs
@ -0,0 +14,4 @@
List<OrderViewModel> orderList = context.Orders
.Select(x => x.GetViewModel)
.ToList();
foreach (var order in orderList)
eegov commented 2023-05-27 21:09:15 +04:00
Collaborator
Copy Link

Одинаковое действие выносится в отдельный метод

Одинаковое действие выносится в отдельный метод
ComputersShop/ComputersShopDatabaseImplement/Implements/OrderStorage.cs
@ -0,0 +18,4 @@
{
string computerName = context.Computers
.SingleOrDefault(x => x.Id == order.ComputerId)?.ComputerName ?? string.Empty;
order.ComputerName = computerName;
eegov commented 2023-05-27 21:09:52 +04:00
Collaborator
Copy Link

Cущности связаны, так что отдельный запрос для получения названия не требуется

Cущности связаны, так что отдельный запрос для получения названия не требуется
ComputersShop/ComputersShopDatabaseImplement/Migrations/ComputersShopDatabaseModelSnapshot.cs
@ -0,0 +142,4 @@
modelBuilder.Entity("ComputersShopDatabaseImplement.Models.Order", b =>
{
b.HasOne("ComputersShopDatabaseImplement.Models.Computer", null)
eegov commented 2023-05-27 21:10:05 +04:00
Collaborator
Copy Link

Связь настроена не до конца

Связь настроена не до конца
eegov closed this pull request 2023-05-27 21:10:25 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kate/ISEbd-21_Vasina_E.S._ComputersShop#5
No description provided.
Delete Branch "lab_3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?