A.Novopoltsev/ISEBbd-22_Novopoltsev_A.A._RenovationWork
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ISEbd-22 Novopolcev A.A. FirstLab01 #1

Closed
A.Novopoltsev wants to merge 2 commits from RenovationWork01 into main
pull from: RenovationWork01
merge into: A.Novopoltsev:main
Conversation 0 Commits 2 Files Changed 60 +4250 -22
A.Novopoltsev commented 2023-03-14 17:11:04 +04:00
Owner
Copy Link
No description provided.
A.Novopoltsev added 2 commits 2023-03-14 17:11:04 +04:00
eegov approved these changes 2023-03-20 09:16:35 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
RenovationWork/RenovationWorkBusinessLogic/BusinessLogic/OrderLogic.cs
@ -0,0 +48,4 @@
public bool StatusUpdate(OrderBindingModel model, OrderStatus newStatus)
{
CheckModel(model);
eegov commented 2023-03-20 09:13:28 +04:00
Collaborator
Copy Link

CheckModel(model, false);

CheckModel(model, false);
RenovationWork/RenovationWorkContracts/Class1.cs
@ -0,0 +1,7 @@
namespace RenovationWorkContracts
eegov commented 2023-03-20 09:14:01 +04:00
Collaborator
Copy Link

Пустых классов быть не должно

Пустых классов быть не должно
RenovationWork/RenovationWorkListImplement/Models/Order.cs
@ -0,0 +15,4 @@
{
public int PackageId { get; private set; }
public string PackageName { get; private set; }
eegov commented 2023-03-20 09:14:53 +04:00
Collaborator
Copy Link

Вычисляемое поле, не хранится в памяти

Вычисляемое поле, не хранится в памяти
RenovationWork/RenovationWorkListImplement/Models/Order.cs
@ -0,0 +54,4 @@
{
return;
}
PackageId = model.PackageId;
eegov commented 2023-03-20 09:15:08 +04:00
Collaborator
Copy Link

Не требуется обновлять все данные, только статус и дату выполнения

Не требуется обновлять все данные, только статус и дату выполнения
eegov closed this pull request 2023-03-20 09:16:42 +04:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: A.Novopoltsev/ISEBbd-22_Novopoltsev_A.A._RenovationWork#1
No description provided.
Delete Branch "RenovationWork01"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?