Battleship/Battleship/CollectionGenericObjects/StorageCollection.cs

@@ -28,6 +28,12 @@ public class StorageCollection<T>
         _storages = new Dictionary<string, ICollectionGenericObjects<T>>();
     }
 
+    private readonly string _collectionKey = "CollectionsStorage";
+
+    private readonly string _separatorForKeyValue = "|";
+
+    private readonly string _separatorItems = ";";
+
     /// <summary>
     /// Добавление коллекции в хранилище
     /// </summary>
@@ -35,10 +41,10 @@ public class StorageCollection<T>
     /// <param name="collectionType">Тип коллекции</param>
     public void AddCollection(string name, CollectionType collectionType)
     {
-        // TODO проверка, что name не пустой и нет в словаре записи с таким ключом
-        if (_storages.ContainsKey(name)) 
+        if (string.IsNullOrEmpty(name) || _storages.ContainsKey(name))
+        {
             return;
-
+        }
         // TODO Прописать логику для добавления
         if (collectionType == CollectionType.List)
         {
@@ -80,69 +86,55 @@ public class StorageCollection<T>
         }
     }
 
-    private readonly string _collectionKey = "CollectionsStorage";
-
-    private readonly string _separatorForKeyValue = "|";
-
-    private readonly string _separatorItems = ";";
-
     /// <summary>
     /// Сохранение информации по кораблям в хранилище в файл
     /// </summary>
     /// <param name="filname"></param>
     /// <returns></returns>
-    public bool SaveData(string filname)
+    public bool SaveData(string filename)
     {
         if (_storages.Count == 0)
         {
             return false;
         }
 
-        if (File.Exists(filname))
+        if (File.Exists(filename))
         {
-            File.Delete(filname);
+            File.Delete(filename);
         }
 
-        if (File.Exists(filname))
+        using (StreamWriter writer = new StreamWriter(filename))
         {
-            File.Delete(filname);
-        }
-
-        StringBuilder sb = new();
-
-        sb.Append(_collectionKey);
-        foreach (KeyValuePair<string, ICollectionGenericObjects<T>> value in _storages)
-        {
-            sb.Append(Environment.NewLine);
-            // не сохраняем пустые коллекции
-            if (value.Value.Count == 0)
+            writer.Write(_collectionKey);
+            foreach (KeyValuePair<string, ICollectionGenericObjects<T>> value in _storages)
             {
-                continue;
-            }
-
-            sb.Append(value.Key);
-            sb.Append(_separatorForKeyValue);
-            sb.Append(value.Value.GetCollectionType);
-            sb.Append(_separatorForKeyValue);
-            sb.Append(value.Value.MaxCount);
-            sb.Append(_separatorForKeyValue);
-
-            foreach (T? item in value.Value.GetItems())
-            {
-                string data = item?.GetDataForSave() ?? string.Empty;
-                if (string.IsNullOrEmpty(data))
+                writer.Write(Environment.NewLine);
+                // не сохраняем пустые коллекции
+                if (value.Value.Count == 0)
                 {
                     continue;
                 }
 
-                sb.Append(data);
-                sb.Append(_separatorItems);
+                writer.Write(value.Key);
+                writer.Write(_separatorForKeyValue);
+                writer.Write(value.Value.GetCollectionType);
+                writer.Write(_separatorForKeyValue);
+                writer.Write(value.Value.MaxCount);
+                writer.Write(_separatorForKeyValue);
+
+                foreach (T? item in value.Value.GetItems())
+                {
+                    string data = item?.GetDataForSave() ?? string.Empty;
+                    if (string.IsNullOrEmpty(data))
+                    {
+                        continue;
+                    }
+
+                    writer.Write(data);
+                    writer.Write(_separatorItems);
+                }
             }
         }
-
-        using FileStream fs = new(filname, FileMode.Create);
-        byte[] info = new UTF8Encoding(true).GetBytes(sb.ToString());
-        fs.Write(info, 0, info.Length);
         return true;
     }
 
@@ -158,62 +150,64 @@ public class StorageCollection<T>
             return false;
         }
 
-        string bufferTextFromFile = "";
-        using (FileStream fs = new(filename, FileMode.Open))
+        using (StreamReader reader = File.OpenText(filename))
         {
-            byte[] b = new byte[fs.Length];
-            UTF8Encoding temp = new(true);
-            while (fs.Read(b, 0, b.Length) > 0)
-            {
-                bufferTextFromFile += temp.GetString(b);
-            }
-        }
+            string str = reader.ReadLine();
 
-        string[] strs = bufferTextFromFile.Split(new char[] { '\n', '\r' }, StringSplitOptions.RemoveEmptyEntries);
-        if (strs == null || strs.Length == 0)
-        {
-            return false;
-        }    
-        if (!strs[0].Equals(_collectionKey))
-        {
-            //если нет такой записи, то это не те файлы
-            return false;
-        }
-
-        _storages.Clear();
-        foreach (string data in strs)
-        {
-            string[] record = data.Split(_separatorForKeyValue, StringSplitOptions.RemoveEmptyEntries);
-            if (record.Length != 4)
-            {
-                continue;
-            }
-
-            CollectionType collectionType = (CollectionType)Enum.Parse(typeof(CollectionType), record[1]);
-            ICollectionGenericObjects<T> collection = StorageCollection<T>.CreateCollection(collectionType);
-            if (collection == null)
+            if (str == null || str.Length == 0)
             {
                 return false;
             }
-            collection.MaxCount = Convert.ToInt32(record[2]);
 
-            string[] set = record[3].Split(_separatorItems, StringSplitOptions.RemoveEmptyEntries);
-            foreach (string elem in set)
+            if (!str.StartsWith(_collectionKey))
             {
-                if (elem?.CreateDrawingWarship() is T warship)
-                {
-                    if (collection.Insert(warship) == -1)
-                    {
-                        return false;
-                    }
-                }
+                //если нет такой записи, то это не те данные
+                return false;
             }
 
-            _storages.Add(record[0], collection);
+            _storages.Clear();
+            string strs = "";
+            while ((strs = reader.ReadLine()) != null)
+            {
+                string[] record = strs.Split(_separatorForKeyValue, StringSplitOptions.RemoveEmptyEntries);
+                if (record.Length != 4)
+                {
+                    continue;
+                }
+
+                CollectionType collectionType = (CollectionType)Enum.Parse(typeof(CollectionType), record[1]);
+                ICollectionGenericObjects<T>? collection = StorageCollection<T>.CreateCollection(collectionType);
+                if (collection == null)
+                {
+                    return false;
+                }
+
+                collection.MaxCount = Convert.ToInt32(record[2]);
+
+                string[] set = record[3].Split(_separatorItems, StringSplitOptions.RemoveEmptyEntries);
+                foreach (string elem in set)
+                {
+                    if (elem?.CreateDrawingWarship() is T bulldozer)
+                    {
+                        if (collection.Insert(bulldozer) == -1)
+                        {
+                            return false;
+                        }
+                    }
+                }
+
+                _storages.Add(record[0], collection);
+            }
         }
         return true;
     }
 
+
+    /// <summary>
+    /// Создание коллекции по типу
+    /// </summary>
+    /// <param name="collectionType"></param>
+    /// <returns></returns>
     private static ICollectionGenericObjects<T>? CreateCollection(CollectionType collectionType)
     {
         return collectionType switch