Доработан Logger, а также исправлена ошибка с удалением лайнера

ProjectLiner/ProjectLiner/CollectionGenericObjects/ListGenericObjects.cs

@@ -1,4 +1,6 @@
 using ProjectLiner.CollectionGenericObjects;
+using ProjectLiner.Exceptions;
+using System.Collections.Generic;
 
 /// <summary>
 /// Параметризованный набор объектов
@@ -10,12 +12,12 @@ public class ListGenericObjects<T> : ICollectionGenericObjects<T>
     /// <summary>
     /// Список объектов, которые храним
     /// </summary>
-    private readonly Dictionary<int, T> _collection;
+    private readonly List<T?> _collection;
     /// <summary>
     /// Максимально допустимое число объектов в списке
     /// </summary>
     private int _maxCount;
-    public int Count => _collection.Keys.Count;
+    public int Count => _collection.Count;
     public int MaxCount
     {
         get
@@ -43,27 +45,34 @@ public class ListGenericObjects<T> : ICollectionGenericObjects<T>
     }
     public T? Get(int position)
     {
-        if (position >= Count || position < 0) return null;
+        // Проверка позиции
+        if (position >= Count || position < 0)
+        {
+            throw new PositionOutOfCollectionException(position);
+        }
         return _collection[position];
     }
     public int Insert(T obj)
     {
-        if (Count > _maxCount) return -1;
-        _collection[Count-1] = obj;
+        if (Count == _maxCount) throw new CollectionOverflowException();
+        _collection.Add(obj);
         return Count;
     }
+
     public int Insert(T obj, int position)
     {
-        if (Count > _maxCount) return -1;
-        _collection[position] = obj;
-        return 1;
+        if (Count == _maxCount) throw new CollectionOverflowException();
+        if (position >= Count || position < 0) throw new PositionOutOfCollectionException();
+        _collection.Insert(position, obj);
+        return position;
     }
-    public T? Remove(int position)
+
+    public T Remove(int position)
     {
-        if (_collection.ContainsKey(position)) return null;
-        T? temp = _collection[position];
-        _collection.Remove(position);
-        return temp;
+        if (position >= Count || position < 0) throw new PositionOutOfCollectionException();
+        T obj = _collection[position];
+        _collection.RemoveAt(position);
+        return obj;
     }
 
     public IEnumerable<T?> GetItems()

ProjectLiner/ProjectLiner/CollectionGenericObjects/MassiveGenericObjects.cs

@@ -1,4 +1,6 @@
 
+using ProjectLiner.Exceptions;
+
 namespace ProjectLiner.CollectionGenericObjects
 {
     /// <summary>
@@ -50,8 +52,7 @@ namespace ProjectLiner.CollectionGenericObjects
 
         public T? Get(int position)
         {
-            if (position < 0 || position >= Count)
-                return null;
+            if (position < 0 || position >= Count) throw new PositionOutOfCollectionException();
             return _collection[position];
         }
 
@@ -65,12 +66,13 @@ namespace ProjectLiner.CollectionGenericObjects
                     return i;
                 }
             }
-            return -1;
+            throw new CollectionOverflowException();
         }
 
         public int Insert(T obj, int position)
         {
-            if (position >= Count || position < 0) return -1;
+
+            if (position >= Count || position < 0) throw new PositionOutOfCollectionException();
             if (_collection[position] == null)
             {
                 _collection[position] = obj;
@@ -96,21 +98,16 @@ namespace ProjectLiner.CollectionGenericObjects
                 }
                 --temp;
             }
-            return -1;
+            throw new CollectionOverflowException();
         }
 
         public T? Remove(int position)
         {
-            if (position < 0 || position >= Count)
-            {
-                return null;
-            }
-
-            //if (_collection[position] == null) return null;
-
-            T? temp = _collection[position];
+            if (position >= Count || position < 0) throw new PositionOutOfCollectionException();
+            T? myObject = _collection[position];
+            if (myObject == null) throw new ObjectNotFoundException();
             _collection[position] = null;
-            return temp;
+            return myObject;
         }
 
         public IEnumerable<T?> GetItems()

ProjectLiner/ProjectLiner/CollectionGenericObjects/StorageCollection.cs

@@ -1,5 +1,6 @@
 using ProjectLiner.CollectionGenericObjects;
 using ProjectLiner.Drawnings;
+using ProjectLiner.Exceptions;
 
 /// <summary>
 /// Класс-хранилище коллекций
@@ -90,10 +91,10 @@ public class StorageCollection<T>
     /// </summary>
     /// <param name="filename">Путь и имя файла</param>
     /// <returns>true - сохранение прошло успешно, false - ошибка при сохранении данных</returns>
-    public bool SaveData(string filename)
+    public void SaveData(string filename)
     {
         if (_storages.Count == 0)
-            return false;
+            throw new Exception("В хранилище отсутствуют коллекции для сохранения");
 
         if (File.Exists(filename))
             File.Delete(filename);
@@ -128,7 +129,6 @@ public class StorageCollection<T>
                 sw.Write(_separatorItems);
             }
         }
-        return true;
     }
 
     /// <summary>
@@ -136,26 +136,24 @@ public class StorageCollection<T>
     /// </summary>
     /// <param name="filename">Путь и имя файла</param>
     /// <returns>true - загрузка прошла успешно, false - ошибка при загрузке данных</returns>
-    public bool LoadData(string filename)
+    public void LoadData(string filename)
     {
         if (!File.Exists(filename))
         {
-            return false;
+            throw new FileNotFoundException($"{filename} не существует");
         }
 
         using (FileStream fs = new(filename, FileMode.Open))
         {
             using StreamReader sr = new StreamReader(fs);
-
-            string str = sr.ReadLine();
-            if (str == null || str.Length == 0)
+            string line = sr.ReadLine();
+            if (line == null || line.Length == 0)
             {
-                return false;
+                throw new Exception("Файл не подходит");
             }
-
-            if (!str.Equals(_collectionKey))
+            if (!line.Equals(_collectionKey))
             {
-                return false;
+                throw new Exception("В файле неверные данные");
             }
             _storages.Clear();
 
@@ -171,7 +169,7 @@ public class StorageCollection<T>
                 ICollectionGenericObjects<T>? collection = StorageCollection<T>.CreateCollection(collectionType);
                 if (collection == null)
                 {
-                    return false;
+                    throw new Exception("Не удалось создать коллекцию");
                 }
 
                 collection.MaxCount = Convert.ToInt32(record[2]);
@@ -180,15 +178,23 @@ public class StorageCollection<T>
                 foreach (string elem in set)
                 {
                     if (elem?.CreateDrawningCommonLiner() is T commonLiner)
+                    {
+                        try
                         {
                             if (collection.Insert(commonLiner) == -1)
-                            return false;
+                            {
+                                throw new Exception("Объект не удалось добавить в коллекцию: ");
+                            }
+                        }
+                        catch (CollectionOverflowException ex)
+                        {
+                            throw new Exception("Коллекция переполнена", ex);
+                        }
                     }
                 }
                 _storages.Add(record[0], collection);
             }
         }
-        return true;
     }
 
     /// <summary>

ProjectLiner/ProjectLiner/Entities/EntityLiner.cs

@@ -77,5 +77,4 @@ public class EntityLiner: EntityCommonLiner
             Color.FromName(strs[3]), Color.FromName(strs[4]),
             Convert.ToBoolean(strs[5]), Convert.ToBoolean(strs[6]), Convert.ToBoolean(strs[7]));
     }
-
 }

ProjectLiner/ProjectLiner/Exceptions/CollectionOverflowException.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace ProjectLiner.Exceptions;
+
+/// <summary>
+/// Класс, описывающий ошибку переполнения коллекции
+/// </summary>
+public class CollectionOverflowException : ApplicationException
+{
+    public CollectionOverflowException(int count) : base("В коллекции превышено допустимое колличество: " + count) { }
+    public CollectionOverflowException() : base() { }
+    public CollectionOverflowException(string message) : base(message) { }
+    public CollectionOverflowException(string message, Exception exception) : base(message, exception) { }
+    protected CollectionOverflowException(SerializationInfo info, StreamingContext contex) : base(info, contex) { }
+}

ProjectLiner/ProjectLiner/Exceptions/ObjectNotFoundException.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace ProjectLiner.Exceptions;
+
+/// <summary>
+/// Класс, описывающий ошибку, что по указанной позиции нет элемента
+/// </summary>
+public class ObjectNotFoundException : ApplicationException
+{
+    public ObjectNotFoundException(int i) : base("Не найден объект по позиции " + i) { }
+    public ObjectNotFoundException() : base() { }
+    public ObjectNotFoundException(string message) : base(message) { }
+    public ObjectNotFoundException(string message, Exception exception) : base(message, exception)
+    { }
+    protected ObjectNotFoundException(SerializationInfo info, StreamingContext contex) : base(info, contex) { }
+}

ProjectLiner/ProjectLiner/Exceptions/PositionOutOfCollectionException.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace ProjectLiner.Exceptions;
+
+/// <summary>
+/// Класс, описывающий ошибку выхода за границы коллекции
+/// </summary>
+[Serializable]
+public class PositionOutOfCollectionException: ApplicationException
+{
+    public PositionOutOfCollectionException(int i) : base("Выход за границы коллекции.Позиция " + i) { }
+    public PositionOutOfCollectionException() : base() { }
+    public PositionOutOfCollectionException(string message) : base(message) { }
+    public PositionOutOfCollectionException(string message, Exception exception) : base(message, exception) { }
+    protected PositionOutOfCollectionException(SerializationInfo info, StreamingContext contex) : base(info, contex) { }
+}

ProjectLiner/ProjectLiner/FormLinerCollection.Designer.cs

@@ -75,7 +75,7 @@
             // buttonCreateCompany
             // 
             buttonCreateCompany.Font = new Font("Segoe UI", 9.75F, FontStyle.Regular, GraphicsUnit.Point);
-            buttonCreateCompany.Location = new Point(8, 520);
+            buttonCreateCompany.Location = new Point(7, 495);
             buttonCreateCompany.Margin = new Padding(5);
             buttonCreateCompany.Name = "buttonCreateCompany";
             buttonCreateCompany.Size = new Size(257, 38);
@@ -96,13 +96,13 @@
             panelStorage.Dock = DockStyle.Top;
             panelStorage.Location = new Point(3, 43);
             panelStorage.Name = "panelStorage";
-            panelStorage.Size = new Size(266, 405);
+            panelStorage.Size = new Size(266, 370);
             panelStorage.TabIndex = 7;
             // 
             // buttonCollectionDel
             // 
             buttonCollectionDel.Font = new Font("Segoe UI", 9.75F, FontStyle.Regular, GraphicsUnit.Point);
-            buttonCollectionDel.Location = new Point(5, 348);
+            buttonCollectionDel.Location = new Point(3, 314);
             buttonCollectionDel.Margin = new Padding(5);
             buttonCollectionDel.Name = "buttonCollectionDel";
             buttonCollectionDel.Size = new Size(257, 38);
@@ -180,7 +180,7 @@
             comboBoxSelectorCompany.DropDownStyle = ComboBoxStyle.DropDownList;
             comboBoxSelectorCompany.FormattingEnabled = true;
             comboBoxSelectorCompany.Items.AddRange(new object[] { "Хранилище" });
-            comboBoxSelectorCompany.Location = new Point(20, 458);
+            comboBoxSelectorCompany.Location = new Point(23, 419);
             comboBoxSelectorCompany.Name = "comboBoxSelectorCompany";
             comboBoxSelectorCompany.Size = new Size(242, 49);
             comboBoxSelectorCompany.TabIndex = 0;

ProjectLiner/ProjectLiner/FormLinerCollection.cs

@@ -1,6 +1,8 @@
 
+using Microsoft.Extensions.Logging;
 using ProjectLiner.CollectionGenericObjects;
 using ProjectLiner.Drawnings;
+using ProjectLiner.Exceptions;
 using System.Windows.Forms;
 
 namespace ProjectLiner;
@@ -18,12 +20,17 @@ public partial class FormLinerCollection : Form
     /// </summary>
     private AbstractCompany? _company = null;
     /// <summary>
+    /// Логгер
+    /// </summary>
+    private readonly ILogger _logger;
+    /// <summary>
     /// Конструктор
     /// </summary>
-    public FormLinerCollection()
+    public FormLinerCollection(ILogger<FormLinerCollection> logger)
     {
         InitializeComponent();
         _storageCollection = new();
+        _logger = logger;
     }
     /// <summary>
     /// Выбор компании
@@ -51,20 +58,24 @@ public partial class FormLinerCollection : Form
     /// </summary>
     /// <param name="airplane"></param>
     private void SetLiner(DrawningCommonLiner liner)
+    {
+        try
         {
             if (_company == null || liner == null)
             {
                 return;
             }
-
             if (_company + liner != -1)
             {
                 MessageBox.Show("Объект добавлен");
                 pictureBox.Image = _company.Show();
+                _logger.LogInformation("Добавлен объект: " + liner.GetDataForSave());
             }
-        else
+        }
+        catch (CollectionOverflowException ex)
         {
-            MessageBox.Show("Не удалось добавить объект");
+            MessageBox.Show(ex.Message, "Результат", MessageBoxButtons.OK, MessageBoxIcon.Error);
+            _logger.LogError("Ошибка: {Message}", ex.Message);
         }
     }
 
@@ -75,26 +86,43 @@ public partial class FormLinerCollection : Form
     /// <param name="e"></param>
     private void ButtonRemoveLiner_Click(object sender, EventArgs e)
     {
-        if (string.IsNullOrEmpty(maskedTextBoxPosition?.Text) || _company == null)
+        if (string.IsNullOrEmpty(maskedTextBox1.Text) || _company == null)
         {
             return;
         }
+
         if (MessageBox.Show("Удалить объект?", "Удаление", MessageBoxButtons.YesNo, MessageBoxIcon.Question) != DialogResult.Yes)
         {
             return;
         }
-        int pos = Convert.ToInt32(maskedTextBoxPosition.Text);
+
+        try
+        {
+            int pos = Convert.ToInt32(maskedTextBox1.Text);
             if (_company - pos != null)
             {
                 MessageBox.Show("Объект удален");
                 pictureBox.Image = _company.Show();
+                _logger.LogInformation("Удаление объекта по индексу " + pos);
             }
             else
             {
                 MessageBox.Show("Не удалось удалить объект");
+                _logger.LogInformation("Не удалось удалить объект из коллекции по индексу " + pos);
+            }
+        }
+        catch (ObjectNotFoundException ex)
+        {
+            MessageBox.Show(ex.Message);
+            _logger.LogError("Ошибка: {Message}", ex.Message);
+        }
+        catch (PositionOutOfCollectionException ex)
+        {
+            MessageBox.Show(ex.Message);
+            _logger.LogError("Ошибка: {Message}", ex.Message);
+        }
     }
 
-    }
     /// <summary>
     /// Передача объекта в другую форму
     /// </summary>
@@ -112,14 +140,19 @@ public partial class FormLinerCollection : Form
         {
             liner = _company.GetRandomObject();
             counter--;
-            if (counter <= 0) break;
+            if (counter <= 0)
+            {
+                break;
+            }
         }
         if (liner == null)
         {
             return;
         }
-        FormLiner form = new FormLiner();
-        form.SetLiner = liner;
+        FormLiner form = new()
+        {
+            SetLiner = liner
+        };
         form.ShowDialog();
     }
     /// <summary>
@@ -147,6 +180,7 @@ public partial class FormLinerCollection : Form
         if (string.IsNullOrEmpty(textBoxCollectionName.Text) || (!radioButtonList.Checked && !radioButtonMassive.Checked))
         {
             MessageBox.Show("Не все данные заполнены", "Ошибка", MessageBoxButtons.OK, MessageBoxIcon.Error);
+            _logger.LogInformation("Не удалось добавить коллекцию: не все данные заполнены");
             return;
         }
         CollectionType collectionType = CollectionType.None;
@@ -160,6 +194,7 @@ public partial class FormLinerCollection : Form
         }
         _storageCollection.AddCollection(textBoxCollectionName.Text, collectionType);
         RerfreshListBoxItems();
+        _logger.LogInformation("Добавлена коллекция типа " + collectionType + " с названием " + textBoxCollectionName.Text);
     }
     /// <summary>
     /// Удаление коллекции
@@ -178,6 +213,7 @@ public partial class FormLinerCollection : Form
             return;
         }
         _storageCollection.DelCollection(listBoxCollection.SelectedItem.ToString());
+        _logger.LogInformation("Удаление коллекции с названием {name}", listBoxCollection.SelectedItem.ToString());
         RerfreshListBoxItems();
     }
     /// <summary>
@@ -233,13 +269,16 @@ public partial class FormLinerCollection : Form
     {
         if (saveFileDialog.ShowDialog() == DialogResult.OK)
         {
-            if (_storageCollection.SaveData(saveFileDialog.FileName))
+            try
             {
+                _storageCollection.SaveData(saveFileDialog.FileName);
                 MessageBox.Show("Сохранение прошло успешно", "Результат", MessageBoxButtons.OK, MessageBoxIcon.Information);
+                _logger.LogInformation("Сохранение в файл: {filename}", saveFileDialog.FileName);
             }
-            else
+            catch (Exception ex)
             {
-                MessageBox.Show("Не сохранилось", "Результат", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                MessageBox.Show(ex.Message, "Результат", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                _logger.LogError("Ошибка: {Message}", ex.Message);
             }
         }
     }
@@ -253,14 +292,21 @@ public partial class FormLinerCollection : Form
     {
         if (openFileDialog.ShowDialog() == DialogResult.OK)
         {
-            if (_storageCollection.LoadData(openFileDialog.FileName))
+            try
             {
+                _storageCollection.LoadData(openFileDialog.FileName);
                 MessageBox.Show("Загрузка прошла успешно", "Результат", MessageBoxButtons.OK, MessageBoxIcon.Information);
-                RerfreshListBoxItems();
-            }
-            else
+                foreach (var collection in _storageCollection.Keys)
                 {
-                MessageBox.Show("Не сохранилось", "Результат", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                    listBoxCollection.Items.Add(collection);
+                }
+                RerfreshListBoxItems();
+                _logger.LogInformation("Загрузка из файла: {filename}", openFileDialog.FileName);
+            }
+            catch (Exception ex)
+            {
+                MessageBox.Show($"Не загрузилось: {ex.Message}", "Результат", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                _logger.LogError("Ошибка: {Message}", ex.Message);
             }
         }
     }

ProjectLiner/ProjectLiner/Program.cs

@@ -1,3 +1,8 @@
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using Serilog;
+
 namespace ProjectLiner
 {
     internal static class Program
@@ -10,8 +15,36 @@ namespace ProjectLiner
         {
             // To customize application configuration such as set high DPI settings or default font,
             // see https://aka.ms/applicationconfiguration.
+
             ApplicationConfiguration.Initialize();
-            Application.Run(new FormLinerCollection());
+            ServiceCollection services = new();
+            ConfigureServices(services);
+            using ServiceProvider serviceProvider = services.BuildServiceProvider();
+            Application.Run(serviceProvider.GetRequiredService<FormLinerCollection>());
+        }
+
+        /// <summary>
+        /// Êîíôèãóðàöèÿ ñåðâèñà DI
+        /// </summary>
+        /// <param name="services"></param>
+        private static void ConfigureServices(ServiceCollection services)
+        {
+            string[] path = Directory.GetCurrentDirectory().Split('\\');
+            string pathNeed = "";
+            for (int i = 0; i < path.Length - 3; i++)
+            {
+                pathNeed += path[i] + "\\";
+            }
+            services.AddSingleton<FormLinerCollection>()
+            .AddLogging(option =>
+            {
+                option.SetMinimumLevel(LogLevel.Information);
+                option.AddSerilog(new LoggerConfiguration()
+                    .ReadFrom.Configuration(new ConfigurationBuilder()
+                        .AddJsonFile($"{pathNeed}serilog.json")
+                        .Build())
+                    .CreateLogger());
+            });
         }
     }
 }

ProjectLiner/ProjectLiner/ProjectLiner.csproj

@@ -8,6 +8,15 @@
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.1" />
+    <PackageReference Include="NLog.Extensions.Logging" Version="5.3.8" />
+    <PackageReference Include="Serilog" Version="3.1.1" />
+    <PackageReference Include="Serilog.AspNetCore" Version="8.0.1" />
+    <PackageReference Include="Serilog.Sinks.Console" Version="5.0.1" />
+    <PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
+  </ItemGroup>
+
   <ItemGroup>
     <Compile Update="Properties\Resources.Designer.cs">
       <DesignTime>True</DesignTime>
@@ -23,4 +32,10 @@
     </EmbeddedResource>
   </ItemGroup>
 
+  <ItemGroup>
+    <None Update="serilog.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+  </ItemGroup>
+
 </Project>

ProjectLiner/ProjectLiner/serilog.json

@@ -0,0 +1,19 @@
+{
+	"Serilog": {
+		"Using": [ 
+		"Serilog.Sinks.File"
+		],
+		"MinimumLevel": "Debug",
+		"WriteTo": [
+			{
+				"Name": "File",
+				"Args": { 
+					"path": "log.log" 
+				}
+			}
+		],
+		"Properties": {
+			"Application": "Sample"
+		}
+	}
+}