frog24/PIbd-21_Barsukov_P._O._WarmlyShip_Hard_Part
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lab1 WarmlyShip hard Barsukov #1

Closed
frog24 wants to merge 3 commits from Lab1 into main
pull from: Lab1
merge into: frog24:main
Conversation 1 Commits 3 Files Changed 12 +13 -18
1 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 137bd293e8 - Show all commits

31
scr/DrawingDecks.java
View File

@ -16,31 +16,26 @@ public class DrawingDecks {
deckType = DeckType.OneDeck;
}
};
public void DrawDeck(int x, int y, int width, int heght, Graphics g, Color MainColor){
g.setColor(MainColor);
g.fillRect(x, y, width, heght);
g.setColor(Color.black);
g.drawRect(x, y, width, heght);
}
public void DrawingDecks(int _startPosX, int _startPosY, Color MainColor, Graphics g){
switch (deckType){
case OneDeck:
g.setColor(MainColor);
g.fillRect(_startPosX + 30, _startPosY + 30, 60, 10);
g.setColor(Color.black);
g.drawRect(_startPosX + 30, _startPosY + 30, 60, 10);
DrawDeck(_startPosX + 30, _startPosY + 30, 60, 10, g, MainColor);
break;
case TwoDecks:
g.setColor(MainColor);
g.fillRect(_startPosX + 30, _startPosY + 30, 60, 10);
g.fillRect(_startPosX + 36, _startPosY + 22, 54, 8);
g.setColor(Color.black);
g.drawRect(_startPosX + 30, _startPosY + 30, 60, 10);
g.drawRect(_startPosX + 36, _startPosY + 22, 54, 8);
DrawDeck(_startPosX + 30, _startPosY + 30, 60, 10, g, MainColor);
eegov commented 2023-12-16 18:56:28 +04:00
Review
Copy Link

Имеется дублирующийся код

Имеется дублирующийся код
DrawDeck(_startPosX + 36, _startPosY + 22, 54, 8, g, MainColor);
break;
case ThreeDecks:
g.setColor(MainColor);
g.fillRect(_startPosX + 30, _startPosY + 30, 60, 10);
g.fillRect(_startPosX + 36, _startPosY + 22, 54, 8);
g.fillRect(_startPosX + 50, _startPosY + 14, 40, 8);
g.setColor(Color.black);
g.drawRect(_startPosX + 30, _startPosY + 30, 60, 10);
g.drawRect(_startPosX + 36, _startPosY + 22, 54, 8);
g.drawRect(_startPosX + 50, _startPosY + 14, 40, 8);
DrawDeck(_startPosX + 30, _startPosY + 30, 60, 10, g, MainColor);
eegov commented 2023-12-16 18:55:11 +04:00
Review
Copy Link

Имеется дублирующийся код

Имеется дублирующийся код
DrawDeck(_startPosX + 36, _startPosY + 22, 54, 8, g, MainColor);
DrawDeck(_startPosX + 50, _startPosY + 14, 40, 8, g, MainColor);
break;
}
}