Igor-Melnikov/ISEbd-21_Melnikov_I.O._Locomotives._Base
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ISEbd-21 Melnikov I.O. Lab work 03 Base #5

Merged
eegov merged 6 commits from LabWork03 into LabWork02 2022-10-21 10:41:37 +04:00
Conversation 0 Commits 6 Files Changed 13 +712 -370
Igor-Melnikov commented 2022-10-20 17:08:03 +04:00
Owner
Copy Link
No description provided.
Igor-Melnikov added 6 commits 2022-10-20 17:08:04 +04:00
Igor-Melnikov requested review from eegov 2022-10-20 17:10:35 +04:00
eegov approved these changes 2022-10-21 10:41:30 +04:00
eegov left a comment
Collaborator
Copy Link

Зачтено с понижением балла(ов)

Зачтено с понижением балла(ов)
Locomotives/Locomotives/MapWithSetLocomotivesGeneric.cs
@ -0,0 +59,4 @@
/// <param name="map"></param>
/// <param name="position"></param>
/// <returns></returns>
public static int operator -(MapWithSetLocomotivesGeneric<T, U> map, int position)
eegov commented 2022-10-21 10:40:54 +04:00
Collaborator
Copy Link

Тип возвращаемого значения выбран неверно

Тип возвращаемого значения выбран неверно
Locomotives/Locomotives/SetLocomotivesGeneric.cs
@ -0,0 +26,4 @@
/// <returns></returns>
public int Insert(T locomotive)
{
T testLocomotive = _places[0];
eegov commented 2022-10-21 10:41:08 +04:00
Collaborator
Copy Link

Правильнее было вызвать Insert(T obj, 0);

Правильнее было вызвать Insert(T obj, 0);
Locomotives/Locomotives/SetLocomotivesGeneric.cs
@ -0,0 +79,4 @@
/// </summary>
/// <param name="position"></param>
/// <returns></returns>
public int Remove(int position)
eegov commented 2022-10-21 10:41:17 +04:00
Collaborator
Copy Link

Тип возвращаемого значения выбран неверно

Тип возвращаемого значения выбран неверно
eegov merged commit 3466ea7251 into LabWork02 2022-10-21 10:41:37 +04:00
Sign in to join this conversation.
Reviewers
No reviewers
eegov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Igor-Melnikov/ISEbd-21_Melnikov_I.O._Locomotives._Base#5
No description provided.
Delete Branch "LabWork03"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?